Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added unit tests for resourceinterpreter webhook configmanager #5832

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Added unit tests for resourceinterpreter webhook configmanager #5832

merged 1 commit into from
Dec 9, 2024

Conversation

anujagrawal699
Copy link
Contributor

Description:
This PR adds comprehensive unit tests for the resourceinterpreter webhook configmanager. These tests verify the core functionality of webhook configuration handling and access, including configuration syncing, merging, and accessor behaviors.

Additions:

  1. pkg/resourceinterpreter/customized/webhook/configmanager/manager_test.go
  2. pkg/resourceinterpreter/customized/webhook/configmanager/accessor_test.go

Test Coverage:

  1. pkg/resourceinterpreter/customized/webhook/configmanager/manager_test.go : 0% to 81%
  2. pkg/resourceinterpreter/customized/webhook/configmanager/accessor_test.go : 0% to 86.4%

What type of PR is this?
/kind feature

Which issue(s) this PR fixes:
Fixes a part of #5470

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 18, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.08%. Comparing base (ae65de4) to head (ccea4d2).
Report is 119 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5832      +/-   ##
==========================================
+ Coverage   46.04%   48.08%   +2.03%     
==========================================
  Files         659      663       +4     
  Lines       53957    54761     +804     
==========================================
+ Hits        24847    26330    +1483     
+ Misses      27494    26718     -776     
- Partials     1616     1713      +97
Flag Coverage Δ
unittests 48.08% <ø> (+2.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango
Copy link
Member

The #5834 will fix the failing tests. Please rebase this PR after #5834.
Sorry for the inconvenience.

@anujagrawal699 anujagrawal699 force-pushed the addedTests-pkg/resourceinterpreter/customized/webhook/configmanager branch from 448e41d to 352446e Compare November 19, 2024 06:35
@anujagrawal699
Copy link
Contributor Author

The #5834 will fix the failing tests. Please rebase this PR after #5834. Sorry for the inconvenience.

Okay, Thanks!

@anujagrawal699
Copy link
Contributor Author

/retest

@karmada-bot
Copy link
Collaborator

@anujagrawal699: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@anujagrawal699
Copy link
Contributor Author

@anujagrawal699: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Hi @XiShanYongYe-Chang , can u trigger a retest?

@XiShanYongYe-Chang
Copy link
Member

Yes~
/retest

@zhzhuang-zju
Copy link
Contributor

/assign

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Dec 3, 2024
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other parts LGTM

pkg/resourceinterpreter/customized/webhook/configmanager/accessor_test.go Outdated
configv1alpha1 "github.com/karmada-io/karmada/pkg/apis/config/v1alpha1"
)

func TestNewResourceExploringAccessor(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test case has been overwritten by the next test case and can be deleted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @XiShanYongYe-Chang , Should i add these two test cases to the getters test or remove it completely?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should i add these two test cases to the getters test

It would be great to do this.

@anujagrawal699 anujagrawal699 force-pushed the addedTests-pkg/resourceinterpreter/customized/webhook/configmanager branch from 352446e to 13dbb09 Compare December 6, 2024 10:12
@anujagrawal699
Added unit tests for resourceinterpreter webhook configmanager
ccea4d2 
Signed-off-by: Anuj Agrawal <[email protected]>

Added unit tests for resourceinterpreter webhook configmanager

Signed-off-by: Anuj Agrawal <[email protected]>

Added unit tests for resourceinterpreter webhook configmanager

Signed-off-by: Anuj Agrawal <[email protected]>
@anujagrawal699 anujagrawal699 force-pushed the addedTests-pkg/resourceinterpreter/customized/webhook/configmanager branch from 13dbb09 to ccea4d2 Compare December 6, 2024 10:47
@anujagrawal699
Copy link
Contributor Author

@XiShanYongYe-Chang Please take a look!

@XiShanYongYe-Chang
Copy link
Member

Thanks a lot
/approve
/cc @zhzhuang-zju

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2024
@zhzhuang-zju
Copy link
Contributor

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2024
@karmada-bot karmada-bot merged commit ff7dc4a into karmada-io:master Dec 9, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@ikaven1024 ikaven1024 Awaiting requested review from ikaven1024

@zhzhuang-zju zhzhuang-zju Awaiting requested review from zhzhuang-zju

Assignees

@zhzhuang-zju zhzhuang-zju

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anujagrawal699 @codecov-commenter @RainbowMango @karmada-bot @XiShanYongYe-Chang @zhzhuang-zju